fix: expand YAML merge keys in profiles template for dbt-fusion compatibility by devin-ai-integration[bot] · Pull Request #983 · elementary-data/dbt-data-reliability

devin-ai-integration · 2026-04-13T14:02:34Z

Summary

Fixes the dbt1005: missing 'type' field in resolved profile output error that causes all three dbt-fusion CI jobs (snowflake, bigquery, databricks_catalog) to fail at the "Check DWH connection" step.

Root cause: The elementary profile in profiles.yml.j2 used YAML merge keys (<<: *anchor) to inherit target configs from elementary_tests. dbt-fusion's Rust-based YAML parser does not resolve YAML merge keys, so the elementary profile's targets were missing the type field (and all other inherited fields), causing the dbt1005 error.

Fix: Replace the Jinja2 for-loop that generated merge-key-based targets with explicit full target definitions. Also removes the now-unused YAML anchors (&name) from elementary_tests. The rendered output is semantically identical — same fields, same values, same behavior.

Ref: Failing workflow run

Review & Testing Checklist for Human

Re-run the "Test all warehouse platforms" workflow and verify the three fusion jobs (snowflake, bigquery, databricks_catalog) now pass the "Check DWH connection" step
Spot-check that the elementary profile targets in the rendered profiles.yml match the elementary_tests targets (same fields, only schema/dataset differs with _elementary suffix)
Verify non-fusion jobs still pass (they should be unaffected since the elementary_tests profile structure is unchanged)

Notes

The trade-off is more verbose template (~150 extra lines) vs. the compact for-loop with merge keys. This is necessary because dbt-fusion's YAML parser fundamentally doesn't support the <<: merge key syntax.
The dremio target's root_path in the elementary profile still points to {{ schema_name }} (not {{ schema_name }}_elementary), matching the previous merge-key behavior where only schema was overridden.
If dbt-fusion adds merge key support in the future, this could be reverted to the compact form.

Link to Devin session: https://app.devin.ai/sessions/076900e0d9464d56b1fa163b657cd7d1
Requested by: @NoyaArie

Summary by CodeRabbit

Chores
- Reworked integration test profile templates for clearer, more explicit target configurations.
- Switched from inherited/merged references to generated explicit target entries, including previously omitted adapters.
- Made schema and dataset naming parameterized so test outputs use predictable, suffix-controlled names for each target.

…tibility dbt-fusion's Rust YAML parser does not resolve YAML merge keys (<<:), causing 'dbt1005: missing type field in resolved profile output' errors when it tries to parse the 'elementary' profile targets that inherited fields via merge keys from the 'elementary_tests' anchors. This commit: - Replaces the Jinja2 for-loop that generated merge-key-based targets in the 'elementary' profile with explicit full target definitions - Removes the now-unused YAML anchors (&name) from elementary_tests - Preserves identical rendered output (same fields, same values) Fixes fusion CI jobs for snowflake, bigquery, and databricks_catalog. Co-Authored-By: Noy Arie <noyarie1992@gmail.com>

devin-ai-integration · 2026-04-13T14:02:37Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

github-actions · 2026-04-13T14:02:44Z

👋 @devin-ai-integration[bot]
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

coderabbitai · 2026-04-13T14:02:50Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3acc7f7c-ec8f-4d30-b696-ff85bed9af52

📥 Commits

Reviewing files that changed from the base of the PR and between 369cd78 and 8eae0af.

📒 Files selected for processing (1)

integration_tests/profiles/profiles.yml.j2

🚧 Files skipped from review as they are similar to previous changes (1)

integration_tests/profiles/profiles.yml.j2

📝 Walkthrough

Walkthrough

Refactored the dbt profile Jinja template to replace YAML anchors and a targets loop with Jinja macros that emit explicit per-adapter target blocks; schema/dataset fields were parameterized and the elementary profile now calls the macro with an _elementary suffix.

Changes

Cohort / File(s)	Summary
dbt profile template `integration_tests/profiles/profiles.yml.j2`	Replaced YAML anchors/merge-keys and the prior Jinja `targets` loop with Jinja macros that define each adapter once and generate concrete `outputs` entries via `all_targets(schema)`.
Adapter configs / schema param `integration_tests/profiles/profiles.yml.j2`	Updated every target to use `schema: {{ schema }}` (parameterized) instead of the previous `{{ schema_name }}`; `bigquery` macro now accepts `dataset` and renders `dataset: {{ dataset }}`.
Elementary profile rendering `integration_tests/profiles/profiles.yml.j2`	The `elementary` profile now invokes `all_targets(schema_name ~ '_elementary')` to apply the explicit `_elementary` suffix for schema/dataset.
Coverage of adapters `integration_tests/profiles/profiles.yml.j2`	Macro generation was expanded to include previously cloud-specific adapters alongside existing ones, producing fully expanded target blocks for all adapters.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐇 I hopped through templates, tidy and bright,

Macros stitched targets from morning to night,
Schemas now flex with a suffix so clever,
BigQuery accepts datasets — neat as a lever,
Targets stand explicit; the meadow's in order.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: replacing YAML merge keys with Jinja macros in the profiles template to resolve dbt-fusion compatibility issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch devin/1776088868-fix-fusion-profiles-merge-keys

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

coderabbitai

🧹 Nitpick comments (1)

integration_tests/profiles/profiles.yml.j2 (1)

169-318: Consider reducing duplication to prevent target drift over time.

Now that merge keys are removed, maintaining two full target maps increases mismatch risk when a field is added/changed in one profile but not the other. A shared Jinja structure (rendered twice with different schema suffix) would keep fusion compatibility and cut maintenance cost.

♻️ Non-blocking refactor sketch

+{% macro render_outputs(schema_suffix='') -%}
+  postgres:
+    type: postgres
+    ...
+    schema: {{ schema_name }}{{ schema_suffix }}
+  ...
+  bigquery:
+    type: bigquery
+    project: {{ bigquery_project | toyaml }}
+    dataset: {{ schema_name }}{{ schema_suffix }}
+    ...
+{%- endmacro %}
+
 elementary_tests:
   target: postgres
   outputs:
-    ... explicit blocks ...
+{{ render_outputs('') | indent(4, true) }}
 
 elementary:
   target: postgres
   outputs:
-    ... explicit blocks ...
+{{ render_outputs('_elementary') | indent(4, true) }}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@integration_tests/profiles/profiles.yml.j2` around lines 169 - 318, The
profiles.yml.j2 duplicates full target maps for two schema variants which risks
drift; refactor by extracting the repeated target map into a single Jinja macro
or reusable block (e.g., define a macro render_target(name, schema_suffix) or a
variable targets_map) and then invoke it twice with the different schema
suffixes (referencing the existing target identifiers like postgres, clickhouse,
trino, dremio, spark, duckdb, sqlserver, vertica, snowflake, bigquery, redshift,
databricks_catalog, fabric, athena) so the same source of truth produces both
"{{ schema_name }}_elementary" variants; ensure all per-target keys
(host/port/user/password/schema/threads/etc.) are defined only inside the macro
and replace the duplicated blocks with calls to that macro passing the
appropriate suffixes.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@integration_tests/profiles/profiles.yml.j2`:
- Around line 169-318: The profiles.yml.j2 duplicates full target maps for two
schema variants which risks drift; refactor by extracting the repeated target
map into a single Jinja macro or reusable block (e.g., define a macro
render_target(name, schema_suffix) or a variable targets_map) and then invoke it
twice with the different schema suffixes (referencing the existing target
identifiers like postgres, clickhouse, trino, dremio, spark, duckdb, sqlserver,
vertica, snowflake, bigquery, redshift, databricks_catalog, fabric, athena) so
the same source of truth produces both "{{ schema_name }}_elementary" variants;
ensure all per-target keys (host/port/user/password/schema/threads/etc.) are
defined only inside the macro and replace the duplicated blocks with calls to
that macro passing the appropriate suffixes.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 658d031d-80ff-44f2-bbaf-76d8b1875830

📥 Commits

Reviewing files that changed from the base of the PR and between edf8d50 and 369cd78.

📒 Files selected for processing (1)

integration_tests/profiles/profiles.yml.j2

devin-ai-integration · 2026-04-13T14:25:22Z

Good suggestion — I considered the Jinja macro approach initially. I went with explicit definitions for this PR to keep the fix simple and reviewable, but a follow-up refactor using a shared macro (as you sketched) would be a nice improvement to prevent drift. Happy to do that as a separate PR if the team prefers.

…ge keys

devin-ai-integration Bot assigned NoyaArie Apr 13, 2026

devin-ai-integration Bot commented Apr 13, 2026

View reviewed changes

coderabbitai Bot reviewed Apr 13, 2026

View reviewed changes

refactor: use Jinja macros to DRY up profiles while avoiding YAML mer…

8eae0af

…ge keys

haritamar approved these changes Apr 13, 2026

View reviewed changes

NoyaArie merged commit afa2383 into master Apr 13, 2026
46 of 47 checks passed

NoyaArie deleted the devin/1776088868-fix-fusion-profiles-merge-keys branch April 13, 2026 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: expand YAML merge keys in profiles template for dbt-fusion compatibility#983

fix: expand YAML merge keys in profiles template for dbt-fusion compatibility#983
NoyaArie merged 2 commits intomasterfrom
devin/1776088868-fix-fusion-profiles-merge-keys

devin-ai-integration Bot commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

devin-ai-integration Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

devin-ai-integration Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

devin-ai-integration Bot commented Apr 13, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review & Testing Checklist for Human

Notes

Summary by CodeRabbit

Uh oh!

devin-ai-integration Bot commented Apr 13, 2026

🤖 Devin AI Engineer

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

coderabbitai Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot commented Apr 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

devin-ai-integration Bot commented Apr 13, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 13, 2026 •

edited

Loading